Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Queue data structure #85

Merged
merged 26 commits into from
Feb 14, 2020
Merged

Added Queue data structure #85

merged 26 commits into from
Feb 14, 2020

Conversation

iamrajiv
Copy link
Contributor

@iamrajiv iamrajiv commented Jan 16, 2020

References to other Issues or PRs or Relevant literature

Fixes #22
Closes #70

Brief description of what is fixed or changed

Added Queue data structure in PyDataStructs

Other comments

@iamrajiv iamrajiv requested a review from czgdp1807 January 16, 2020 09:35
@czgdp1807
Copy link
Member

Thanks for the PR.
Some points,

  1. IMHO, we should use, DynamicOneDimensionalArray for self.queue(which I think can be renamed as self.items).
  2. Is Queue a double ended queue?
  3. IMHO, we can remove size as an argument for initialising as DynamicOneDimensionalArray is capable of handling variable sizes.

@czgdp1807
Copy link
Member

See, current implementation of stacks. We can have similar design for Queue as well. An ArrayQueue for array implementation.

@czgdp1807
Copy link
Member

@iamrajiv Are you interested to continue work on this PR? Please let us know. Thanks.

@czgdp1807
Copy link
Member

It looks like the doctests are failing. See, here.

@czgdp1807
Copy link
Member

Please check that you have enabled Allow edits from maintainers.

@czgdp1807
Copy link
Member

No, I will push some commits by day after tomorrow.

@czgdp1807
Copy link
Member

@iamrajiv Please provide your name and email id if you want your name to be included in AUTHORS file.

@iamrajiv
Copy link
Contributor Author

thank you @czgdp1807 for commits I will figure out the tests
Name: Rajiv Ranjan Singh
Email: rajivperfect007@gmail.com

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #85 into master will decrease coverage by 0.112%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##            master       #85       +/-   ##
=============================================
- Coverage   97.385%   97.273%   -0.113%     
=============================================
  Files           30        32        +2     
  Lines         1721      1797       +76     
=============================================
+ Hits          1676      1748       +72     
- Misses          45        49        +4     
Impacted Files Coverage Δ
.../miscellaneous_data_structures/tests/test_queue.py 100.000% <0.000%> (ø)
...datastructs/miscellaneous_data_structures/queue.py 92.857% <0.000%> (ø)

Impacted file tree graph

@czgdp1807
Copy link
Member

Merging. Thanks.

@czgdp1807 czgdp1807 merged commit 1765955 into codezonediitj:master Feb 14, 2020
@iamrajiv iamrajiv deleted the queue branch February 14, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Queue
2 participants