Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate limiting - Untested #40

Merged
merged 5 commits into from
Sep 30, 2017
Merged

Add rate limiting - Untested #40

merged 5 commits into from
Sep 30, 2017

Conversation

grimd34th
Copy link
Contributor

Add a sleep after the function call with python's standard time.sleep and a default of 0 and a command line option to set the limit

@codingo
Copy link
Owner

codingo commented Sep 29, 2017

Not ignoring either of these - going to have to build out a new test case for them so will review in 24 hours.

@codingo codingo self-assigned this Sep 29, 2017
Copy link
Owner

@codingo codingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of changes to master since this was committed meant some merging was necessary but on the whole this looks good and ready for commit.

@codingo
Copy link
Owner

codingo commented Sep 30, 2017

Hi @grimd34th I've fixed a number of issues to bring this back up to date with master however in testing it doesn't appear to sleep (I've tried passing numerous values). Could you revisit the code in its new state and see if you can figure out why?

@codingo
Copy link
Owner

codingo commented Sep 30, 2017

Disregard - fixed. Bug was introduced by me when I did the merge.

@codingo codingo merged commit e676ba0 into codingo:master Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants