Skip to content

Commit

Permalink
feat: replace youtube player to iframe_youtube_place (#73)
Browse files Browse the repository at this point in the history
  • Loading branch information
deep-diver authored Jun 11, 2021
1 parent c62a593 commit f644afb
Show file tree
Hide file tree
Showing 11 changed files with 82 additions and 239 deletions.
6 changes: 6 additions & 0 deletions client/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,13 @@ PODS:
- Flutter
- OrderedSet (~> 5.0)
- OrderedSet (5.0.0)
- url_launcher (0.0.1):
- Flutter

DEPENDENCIES:
- Flutter (from `Flutter`)
- flutter_inappwebview (from `.symlinks/plugins/flutter_inappwebview/ios`)
- url_launcher (from `.symlinks/plugins/url_launcher/ios`)

SPEC REPOS:
trunk:
Expand All @@ -22,11 +25,14 @@ EXTERNAL SOURCES:
:path: Flutter
flutter_inappwebview:
:path: ".symlinks/plugins/flutter_inappwebview/ios"
url_launcher:
:path: ".symlinks/plugins/url_launcher/ios"

SPEC CHECKSUMS:
Flutter: 434fef37c0980e73bb6479ef766c45957d4b510c
flutter_inappwebview: bfd58618f49dc62f2676de690fc6dcda1d6c3721
OrderedSet: aaeb196f7fef5a9edf55d89760da9176ad40b93c
url_launcher: 6fef411d543ceb26efce54b05a0a40bfd74cbbef

PODFILE CHECKSUM: aafe91acc616949ddb318b77800a7f51bffa2a4c

Expand Down
184 changes: 0 additions & 184 deletions client/lib/test-server.dart

This file was deleted.

17 changes: 0 additions & 17 deletions client/lib/utils/formatter.dart

This file was deleted.

5 changes: 2 additions & 3 deletions client/lib/widgets/detail/header.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'package:flutter/material.dart';
import 'package:intl/intl.dart';
import 'package:pr12er/protos/pkg/pr12er/messages.pb.dart';
import 'package:pr12er/utils/formatter.dart';

// ignore: must_be_immutable
class HeaderWidget extends StatelessWidget {
Expand Down Expand Up @@ -43,12 +42,12 @@ class HeaderWidget extends StatelessWidget {
const SizedBox(width: 8),
const Icon(Icons.remove_red_eye),
const SizedBox(width: 8),
Text(reformatNumbers(video.numberOfViews.toInt()),
Text(NumberFormat.compact().format(video.numberOfViews),
style: const TextStyle(fontSize: 18)),
const SizedBox(width: 15),
getLikeIcon(),
const SizedBox(width: 8),
Text(reformatNumbers(video.numberOfLike.toInt()),
Text(NumberFormat.compact().format(video.numberOfLike),
style: const TextStyle(fontSize: 18)),
];
}
Expand Down
17 changes: 8 additions & 9 deletions client/lib/widgets/detail/youtube.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'package:flutter/material.dart';
import 'package:youtube_player_flutter/youtube_player_flutter.dart';
// import 'package:youtube_player_flutter/youtube_player_flutter.dart';
import 'package:youtube_player_iframe/youtube_player_iframe.dart';

class YoutubeWidget extends StatefulWidget {
final String youtubeId;
Expand All @@ -22,15 +23,13 @@ class _DetailState extends State<YoutubeWidget> {

@override
Widget build(BuildContext context) {
return YoutubePlayerBuilder(
player: YoutubePlayer(
controller: _controller,
return YoutubePlayerControllerProvider(
// Provides controller to all the widget below it.
controller: _controller,
child: const YoutubePlayerIFrame(
// ignore: avoid_redundant_argument_values
aspectRatio: 16 / 9,
),
builder: (context, player) {
return Column(
children: [player],
);
},
);
}
}
63 changes: 62 additions & 1 deletion client/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,11 @@ packages:
description: flutter
source: sdk
version: "0.0.0"
flutter_web_plugins:
dependency: transitive
description: flutter
source: sdk
version: "0.0.0"
frontend_server_client:
dependency: transitive
description:
Expand Down Expand Up @@ -413,6 +418,13 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "3.0.0"
plugin_platform_interface:
dependency: transitive
description:
name: plugin_platform_interface
url: "https://pub.dartlang.org"
source: hosted
version: "2.0.0"
pool:
dependency: transitive
description:
Expand Down Expand Up @@ -593,6 +605,48 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "1.3.0"
url_launcher:
dependency: transitive
description:
name: url_launcher
url: "https://pub.dartlang.org"
source: hosted
version: "6.0.6"
url_launcher_linux:
dependency: transitive
description:
name: url_launcher_linux
url: "https://pub.dartlang.org"
source: hosted
version: "2.0.0"
url_launcher_macos:
dependency: transitive
description:
name: url_launcher_macos
url: "https://pub.dartlang.org"
source: hosted
version: "2.0.0"
url_launcher_platform_interface:
dependency: transitive
description:
name: url_launcher_platform_interface
url: "https://pub.dartlang.org"
source: hosted
version: "2.0.3"
url_launcher_web:
dependency: transitive
description:
name: url_launcher_web
url: "https://pub.dartlang.org"
source: hosted
version: "2.0.1"
url_launcher_windows:
dependency: transitive
description:
name: url_launcher_windows
url: "https://pub.dartlang.org"
source: hosted
version: "2.0.0"
vector_math:
dependency: transitive
description:
Expand Down Expand Up @@ -649,6 +703,13 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "8.0.0"
youtube_player_iframe:
dependency: "direct main"
description:
name: youtube_player_iframe
url: "https://pub.dartlang.org"
source: hosted
version: "2.0.0"
sdks:
dart: ">=2.12.0 <3.0.0"
flutter: ">=1.22.2"
flutter: ">=2.0.0"
1 change: 1 addition & 0 deletions client/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ dependencies:
protobuf: ^2.0.0
provider: ^5.0.0
youtube_player_flutter: ^8.0.0
youtube_player_iframe: ^2.0.0

dev_dependencies:
build_runner: ^2.0.4
Expand Down
Loading

0 comments on commit f644afb

Please sign in to comment.