Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the client properly reconnects to both Telegram and XMPP after network outage #17

Closed
ForNeVeR opened this issue Oct 23, 2017 · 5 comments
Assignees

Comments

@ForNeVeR
Copy link
Member

Perform the following manual test:

  1. Start Emulsion
  2. Make sure it connected to both Telegram and XMPP
  3. Disable the network connection
  4. Enable the network connection
  5. Make sure Emulsion works after reconnection

Probably write some unit tests to check that (possibly weak places will be discovered in the process of manual testing).

@ForNeVeR
Copy link
Member Author

ForNeVeR commented Apr 7, 2019

Alright it somewhat works, but at the same time it doesn't.

  1. When the bot is disconnected, it consumes too much CPU (and it indefinitely spams messages about "Error: One or more errors occurred. (No such host is known)"
  2. It looks like everything is pretty much fucked if the network connection isn't available when the bot is started

@ForNeVeR
Copy link
Member Author

ForNeVeR commented Apr 7, 2019

  1. It looks like everything is pretty much fucked if the network connection isn't available when the bot is started

Interestingly enough, the Telegram side of the bot connects properly then. It looks like the XMPP one is just sending the messages to the wrong actor?

@ForNeVeR ForNeVeR self-assigned this Apr 7, 2019
@ForNeVeR
Copy link
Member Author

ForNeVeR commented May 12, 2019

The issue was that the Telegram actor tried to kill itself via PoisonPill, but it wasn't effective: now-"dead" actor was still receiving the messages again and again. We need to seriously revisit the thread management schema.

@ForNeVeR
Copy link
Member Author

ForNeVeR commented Jul 7, 2019

Blocked on: #29, #41, #42.

@ForNeVeR ForNeVeR mentioned this issue Jul 9, 2019
19 tasks
@ForNeVeR
Copy link
Member Author

Verified, works on current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant