Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't properly reconnect after proper server disconnection #41

Closed
ForNeVeR opened this issue Jul 7, 2019 · 1 comment · Fixed by #59
Closed

Doesn't properly reconnect after proper server disconnection #41

ForNeVeR opened this issue Jul 7, 2019 · 1 comment · Fixed by #59
Assignees
@ForNeVeR
Labels
kind:bug

Comments

@ForNeVeR
Copy link
Member

ForNeVeR commented Jul 7, 2019

  1. Start Emulsion, connect to XMPP server
  2. Shut down the server (Prosody in my case)
  3. The server will properly close the XML stream
  4. But the client won't detect it

The reason is in this line of code: https://github.com/vitalyster/SharpXMPP/blob/6a187edbe8b6ebf93c90dd10c622f944419e407f/SharpXMPP.Shared/XmppTcpConnection.cs#L79

Prosody closes the XML correctly, thus it will just start returning false in loop instead of trying to read more from the stream and failing.
@ForNeVeR ForNeVeR self-assigned this Jul 7, 2019
This was referenced Jul 7, 2019
Closed
Closed
@ForNeVeR
Copy link
Member Author

Depends on vitalyster/SharpXMPP#21.

ForNeVeR added a commit that referenced this issue Jul 13, 2019
@ForNeVeR
Update to a newer unpublished version of SharpXMPP (#41)
942e785
ForNeVeR added a commit that referenced this issue Jul 13, 2019
@ForNeVeR
Update to SharpXMPP 0.0.2 (#41)
be1f214
@ForNeVeR ForNeVeR mentioned this issue Jul 13, 2019
Merged
ForNeVeR added a commit that referenced this issue Jul 20, 2019
@ForNeVeR
Update to SharpXMPP 0.0.2 (#41)
4956dab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ForNeVeR ForNeVeR

Labels
kind:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the XMPP reconnection issues codingteam/emulsion
1 participant
@ForNeVeR