Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New XMPP client #79

Merged
merged 22 commits into from
Sep 21, 2019
Merged

New XMPP client #79

merged 22 commits into from
Sep 21, 2019

Conversation

ForNeVeR
Copy link
Member

@ForNeVeR ForNeVeR commented Sep 5, 2019 •
edited
Loading

Closes #18.

TODO:

  • Add tests for the new XMPP client
  • Use the new client instead of an old one
  • Add tests for all the remaining new/changed code
  • Fix the remaining TODOs
  • Check if the old test names correspond to the new naming
  • Perform the manual tests

@ForNeVeR ForNeVeR self-assigned this Sep 5, 2019
@ForNeVeR
Migrate to JetBrains.Lifetimes (#18)
34814a4
@ForNeVeR
Add tests for the simplified connect function, add IXmppClient (#18)
4817e38 
Also add and clarify some TODO comments.
@ForNeVeR
Add tests for the enter function (#18)
9451b78
@ForNeVeR
Add tests for the sendRoomMessage function (#18)
68955c0
@ForNeVeR
Add a test for the awaitMessageDelivery function (#18)
e79f39d
@ForNeVeR
Add an XmppClient-based implementation for IXmppClient (#18)
beacbe8
@ForNeVeR
Migrate to the IXmppClient-based XMPP implementation (#18)
69ed8e3
@ForNeVeR
Wait for the message delivery before trying to send next message (#18)
2857785
@ForNeVeR
Add test for ExceptionUtils (#18)
6512479
@ForNeVeR
Add tests for the Lifetimes module (#18)
85c2f7c
@ForNeVeR
Add tests for EmulsionXmpp (#18)
98d75bc
@ForNeVeR
Small formatting fixes around XmppClient (#18)
306dbba
@ForNeVeR
Make messageId a required parameter for SharpXmppHelper.message (#18)
f4f2ad7
@ForNeVeR
Small formatting fix for XmppClientTests (#18)
641eb5a
@ForNeVeR
Fix leave detection (#18)
acf2096
@ForNeVeR ForNeVeR removed their assignment Sep 8, 2019
@ForNeVeR ForNeVeR requested a review from gsomix September 8, 2019 14:23
@ForNeVeR ForNeVeR marked this pull request as ready for review September 8, 2019 14:23
@ForNeVeR
Copy link
Member Author

ForNeVeR commented Sep 8, 2019

Alright, this is ready!

ForNeVeR
ForNeVeR commented Sep 14, 2019
View reviewed changes
Emulsion/Lifetimes.fs Outdated Show resolved Hide resolved
@ForNeVeR
Copy link
Member Author

I have reviewed that. Everything is okay.

@ForNeVeR ForNeVeR merged commit 1ddfe2f into master Sep 21, 2019
@ForNeVeR ForNeVeR deleted the feature/18.async-xmpp branch September 21, 2019 10:57
@ForNeVeR ForNeVeR mentioned this pull request Sep 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsomix gsomix Awaiting requested review from gsomix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XMPP room connection handler
1 participant
@ForNeVeR