Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn overriding [name].js to [name].js #550

Closed
jason-ha opened this issue Mar 21, 2023 · 0 comments · Fixed by #559
Closed

Don't warn overriding [name].js to [name].js #550

jason-ha opened this issue Mar 21, 2023 · 0 comments · Fixed by #559
Labels
flag: Community help wanted

Comments

@jason-ha
Copy link

  • Operating System: Windows+
  • Node Version: 16.19.0
  • NPM Version: 8.19.3
  • webpack Version: 5.76.1
  • karma-webpack Version: 5.0.0

Expected Behavior / Situation

When webpack config's output.filename is '[name].js' there are no warnings.

Actual Behavior / Situation

When any output.filename is set, karma-webpack will warn even when result is the same setting as in:

karma-webpack does not currently support customized filenames via
webpack output.filename, if this is something you need consider opening an issue.
defaulting [name].js to [name].js.

Modification Proposal

Also check that value is not already '[name].js'. Okay to delete as replace; just don't warn.
codymikol added a commit that referenced this issue Oct 21, 2023
@codymikol
fix(controller): don't warn if name is default
efb1f3d 
This prevents a warning that occurs when output.filename
is set to '[name].js'. Because this is the default, there
is no need to warn the user as no change will happen.

Fixes #550
@codymikol codymikol mentioned this issue Oct 21, 2023
Merged
codymikol added a commit that referenced this issue Oct 21, 2023
@codymikol
fix(controller): don't warn if name is default (#559)
0670955 
This prevents a warning that occurs when output.filename
is set to '[name].js'. Because this is the default, there
is no need to warn the user as no change will happen.

Fixes #550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag: Community help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(controller): don't warn if name is default codymikol/karma-webpack
2 participants
@codymikol @jason-ha