chore(test): set up integration testing #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoto13
reviewed
Jan 14, 2021
| // Explicitly turn off reporters so the simulated test results are not confused with the actual results. | ||
| reporters: [], | ||
| port: 2389, | ||
| logLevel: 'OFF', |
There was a problem hiding this comment.
Can this be the reason, why you don't see logs?
There was a problem hiding this comment.
This was added right at the end to keep the tests from being noisy, unrelated to the issue I was having. I'll try to get a repro up sometime today.
There was a problem hiding this comment.
Looking at this made me realize that I totally missed pushing one of my files though 🤦♂️
codymikol
changed the title
This will ensure that karma-webpack can run as expected within a live karma server. Fixes #460
codymikol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that karma-webpack
can run as expected within a live
karma server.
Fixes #460
This PR contains a:
Motivation / Use-Case
This will make it easier to update dependencies as it will ensure that karma-webpack will still work in at least a basic setup. This also lays groundwork for adding additional integration tests as well for more niche scenarios.
Breaking Changes
N/A
Additional Info
This also introduces puppeteer as a dev dependency as I found it to be the most best headless option for doing an integration test.