Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year of the linux desktop #468

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Year of the linux desktop #468

merged 1 commit into from
Jan 29, 2021

Conversation

codymikol
Copy link
Owner

chore(test): fix testing on linux

Some systems require the CHROME_BIN env
variable to be set for karma to hook
into the chrome binary for testing.
I noticed this while setting up
karma-webpack on my linux desktop.

Fixes N/A

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

This allows karma-webpack tests to run in certain linux environments where CHROME_BIN is not set automatically

Breaking Changes

N/A

Additional Info

N/A

Some systems require the CHROME_BIN env
variable to be set for karma to hook
into the chrome binary for testing.
I noticed this while setting up
karma-webpack on my linux desktop.

Fixes N/A
@codymikol codymikol changed the base branch from master to next January 29, 2021 03:02
@codymikol codymikol merged commit 57b131e into codymikol:next Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant