Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default packages #34

Merged
merged 1 commit into from
May 23, 2020

Conversation

BrianHenryIE
Copy link
Contributor

If the "packages" config for mozart under composer's extras field is absent, use the full list of composer's required packages.

If the "packages" config for mozart under composer's extras field is absent, use the full list of composer's required packages.
Copy link

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense

@coenjacobs coenjacobs merged commit 9843b32 into coenjacobs:master May 23, 2020
@coenjacobs
Copy link
Owner

Sorry to leave this hanging for so long, it makes perfect sense. Thanks for your contribution, @BrianHenryIE!

@BrianHenryIE
Copy link
Contributor Author

This merge did not work. On line 50 array_keys(get_object_vars($this->config->require)), $this->config is the Mozart extra object, but it needs to be the full composer.json object whose require key is to be used. The PR as is works, so can you re-merge, or should I create a new one?

I also think the use of $composer = in the PR is clearer than using $config twice to mean two different things.

@BrianHenryIE BrianHenryIE deleted the default-packages branch May 3, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants