Log SourceArtifactException in addition to IOException during error b…

…ubbling. This will help confirm that all unexpected IOExceptions are coming via include scanning. PiperOrigin-RevId: 407165070
coeuvre · Nov 2, 2021 · 84a9df5 · 84a9df5
1 parent dbec72e
commit 84a9df5
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/main/java/com/google/devtools/build/skyframe/AbstractExceptionalParallelEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/AbstractExceptionalParallelEvaluator.java
@@ -540,7 +540,10 @@ Map<SkyKey, ValueWithMetadata> bubbleErrorUp(
         Thread.interrupted();
       }
       // TODO(b/166268889, b/172223413): remove when fixed.
-      if (completedRun && error.getException() instanceof IOException) {
+      if (completedRun
+          && error.getException() != null
+          && (error.getException() instanceof IOException
+              || error.getException().getClass().getName().endsWith("SourceArtifactException"))) {
         logger.atInfo().log(
             "SkyFunction did not rethrow error, may be a bug that it did not expect one: %s"
                 + " via %s, %s (%s)",