Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade npm to 8.13.1 (8.5+) and regenerate package-lock.json #314

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Jun 24, 2022

so that its version resolution matches the new npm behavior used on Github action.

Reference: npm/cli#4684

Before

https://github.com/cofacts/rumors-line-bot/runs/7038118527?check_suite_focus=true (on master branch)
image

After

https://github.com/cofacts/rumors-line-bot/actions/runs/2554485738 (on this branch)
image

so that its version resolution matches the new npm behavior used on Github action
@MrOrz MrOrz requested a review from nonumpa June 24, 2022 08:38
@MrOrz MrOrz self-assigned this Jun 24, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2554559934

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.946%

Totals Coverage Status
Change from base Build 2253962583: 0.0%
Covered Lines: 954
Relevant Lines: 1081

💛 - Coveralls

Copy link
Member

@nonumpa nonumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @MrOrz for the fix!

@nonumpa nonumpa merged commit cc013c5 into master Jun 24, 2022
@nonumpa nonumpa deleted the fix-actions branch June 24, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants