Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GBT base score to block output #81

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Add GBT base score to block output #81

merged 2 commits into from
Jul 4, 2022

Conversation

ThebTron
Copy link
Collaborator

@ThebTron ThebTron commented Jul 1, 2022

Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

This PR addresses #80. GBT models imported from scikit-learn have an additional constant base score that is added to the prediction of the model. This doesn't apply for lightgbm and the base score defaults to zero. I also added a note to the jupyter notebook that only lightgbm and scikit-learn tree model inputs are officially supported.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #81 (8aac10f) into main (3e2f9e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   94.18%   94.19%           
=======================================
  Files          24       24           
  Lines        1239     1240    +1     
  Branches      192      192           
=======================================
+ Hits         1167     1168    +1     
  Misses         42       42           
  Partials       30       30           
Impacted Files Coverage Δ
src/omlt/gbt/gbt_formulation.py 93.65% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2f9e4...8aac10f. Read the comment docs.

@tsaycal tsaycal merged commit f84e08d into main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants