Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Vulkan location and structure #1018

Closed
kkoreilly opened this issue Jul 17, 2024 · 3 comments · Fixed by #1112
Closed

Resolve Vulkan location and structure #1018

kkoreilly opened this issue Jul 17, 2024 · 3 comments · Fixed by #1112
Labels
enhancement A new feature request low priority Lower priority; do eventually but not urgent needs discussion Need to discuss what to do

Comments

@kkoreilly
Copy link
Member

Describe the feature

If we continue to use Vulkan, we should move https://github.com/goki/vulkan somewhere into the Cogent Core space, try again to merge it upstream, or use a better Vulkan package. We may also use WebGPU instead (see #507).

Relevant code

No response

@kkoreilly kkoreilly added enhancement A new feature request low priority Lower priority; do eventually but not urgent needs discussion Need to discuss what to do labels Jul 17, 2024
@theclapp
Copy link

While you're at it, it might (or, of course, might not) be useful to look at some of the other forks of vulkan-go/vulkan (https://github.com/vulkan-go/vulkan/network) for useful code and/or bug fixes. And perhaps even some of their open PRs.

I mention this in part because I ran into a bug in a library I'd forked, and committed a fix, and went to upstream, only to see that they had an unmerged PR to fix the same issue that was two years old. So I was bitter about that, but my point is sometimes there's useful code in other people's forks and/or PRs.

Apologies if you've already thought of all that. :)

@kkoreilly
Copy link
Member Author

Thank you for the suggestion! I think we already merged any other useful forks into our fork in addition to the improvements we made ourselves. Regardless, we are planning to migrate to WebGPU now (#507), so hopefully all of these issues will become irrelevant.

@rcoreilly
Copy link
Member

I didn't know about that /network feature! very handy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature request low priority Lower priority; do eventually but not urgent needs discussion Need to discuss what to do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants