Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene.contentsSize underestimates vertical size with wrapped (text?) elements #1307

Open
rcoreilly opened this issue Nov 14, 2024 · 0 comments
Labels
bug Something isn't working correctly confirmed This bug has been confirmed

Comments

@rcoreilly
Copy link
Member

Describe the bug

using the new ResizeToContents method from #1306 the window was likely mis-sized because of the wrapped text -- if you start from other narrower sizes you get different resulting sizes. This is also a function of whether the buttons are wrapped in the flex layout. It is tricky because the starting size you give it is the whole screen, so it doesn't wrap that. But the contentsSize method operating on a current scene will probably use the current wrapping, so there can be mismatches. Need further investigation.

You can pass a suitable extra size amount, as we now do, to make it work in any given situation, but it would be good to fix the general issue at some point.

How to reproduce

run examples/demo and go to Widgets/Dialogs and click on Resize to contents button.

Example code

No response

Relevant output

No response

Platform

macOS

@rcoreilly rcoreilly added the bug Something isn't working correctly label Nov 14, 2024
@kkoreilly kkoreilly added the confirmed This bug has been confirmed label Nov 14, 2024
@kkoreilly kkoreilly added this to Bugs Nov 18, 2024
@github-project-automation github-project-automation bot moved this to Todo in Bugs Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly confirmed This bug has been confirmed
Projects
Status: Todo
Development

No branches or pull requests

2 participants