Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A set of stage / window sizing fixes #1306

Merged
merged 6 commits into from
Nov 15, 2024
Merged

A set of stage / window sizing fixes #1306

merged 6 commits into from
Nov 15, 2024

Conversation

rcoreilly
Copy link
Member

@rcoreilly rcoreilly commented Nov 14, 2024 •
edited
Loading

  • change the popup sizing and positioning logic from c881462 to only apply when popup is a significant fraction of the size of the source window that it is a popup of. much better.

  • add an option on Stage to disable min size of a new window, and also to specify the size of the window manually.

  • add a ResizeToContents function to Scene that resizes an existing Scene to fit current contents, and rename prefSize -> contentSize

fixes #1283 and fixes #1298

@rcoreilly
change the popup sizing and positioning logic from c881462 to only ap…
b054088 
…ply when popup is a significant fraction of the size of the source window that it is a popup of. much better.
@rcoreilly rcoreilly marked this pull request as draft November 14, 2024 06:02
@rcoreilly
Scene.ResizeToContents and rename contentsSize -- added a button in w…
b144e8c 
…idgets / dialogs to call it -- seems to cut off a bit of size on my mac but we should see how general that is. also system.Window.SetSize was not implemented on desktop! how is that possible?
@rcoreilly
Copy link
Member Author

@kkoreilly can you test resize to contents?

@rcoreilly rcoreilly mentioned this pull request Nov 14, 2024
Open
@rcoreilly rcoreilly marked this pull request as ready for review November 14, 2024 07:33
kkoreilly
kkoreilly requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@kkoreilly kkoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely somewhat buggy for me. Also centralized docs would be nice...

core/render.go Outdated Show resolved Hide resolved
core/scene.go Outdated Show resolved Hide resolved
core/scene.go Outdated Show resolved Hide resolved
core/scene.go Outdated Show resolved Hide resolved
core/stage.go Outdated Show resolved Hide resolved
examples/demo/demo.go Outdated Show resolved Hide resolved
examples/demo/demo.go Outdated Show resolved Hide resolved
system/driver/desktop/window.go Show resolved Hide resolved
kkoreilly
kkoreilly requested changes Nov 14, 2024
View reviewed changes
core/stage.go Outdated Show resolved Hide resolved
core/scene.go Show resolved Hide resolved
examples/demo/demo.go Outdated Show resolved Hide resolved
@kkoreilly kkoreilly merged commit 43c6bd6 into main Nov 15, 2024
1 check passed
@kkoreilly kkoreilly deleted the stagesize branch November 15, 2024 20:31
@kkoreilly kkoreilly mentioned this pull request Nov 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkoreilly kkoreilly kkoreilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support a growing window
2 participants
@rcoreilly @kkoreilly