-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run race detector in V2 #671
Comments
The Goki Demo fails to start very occasionally on my windows computer; I would say about 1% of the time. |
Did this with async test example, and it looks pretty clean (after fixing some things): just the atomic flag checking routines -- which are fine. key command for running that prevents immediate fail in vulkan / glfw:
|
just commented out StyMu and BBoxMu and ran async race detector without any additional issues related to those things, so likely can remove pending further testing. |
to be more explicit: everything is protected by the RenderCtx mutex lock that happens at the start of event processing, rendering, and Async processing, so we don't need finer-grained mutexes within widgets etc. This strategy precludes parallel processing of widgets, but that doesn't make sense for lots of reasons anyway, so this big global mutex strategy is probably the best way to go. |
After more testing, it is clear that |
should be all good but might be a few cases here and there.
Also, can look at need for style and other mutexes -- in general most likely not needed due to way things get updated and top-level UpdateStartAsync logic.
The text was updated successfully, but these errors were encountered: