support screen name in various cases #1341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic perversely associates monitor with fullscreen so we need to do a workaround.
…ecified in screeen specific coords.
…e.RunMain() helper.
…dow position, geom. also clear cache when doing restore so immediately prior resize / move don't register as user updates.
… so removed that commented-out code
kkoreilly
requested changes
Nov 26, 2024
system/screen.go
Outdated
| if cpos.Y == -32000 { | ||
| cpos.Y = 50 | ||
| if TheApp.Platform() == Windows { | ||
| if csz.Y > (scsz.Y - 20) { // leave room for title |
There was a problem hiding this comment.
There is a programmatic way to determine this with glfwGetWindowFrameSize.
…Point structure removes tons of absolutely pointless conversion code
….Screen; make AppSingle consistent with that behavior
…reen video mode resolution
kkoreilly
requested changes
Nov 27, 2024
system/driver/base/window_multi.go
Outdated
| @@ -39,6 +39,9 @@ type WindowMulti[A system.App, D system.Drawer] struct { | |||
| // PixSize is the pixel size of the window in raw display dots | |||
| PixSize image.Point `label:"Pixel size"` | |||
|
|
|||
| // FrameSize of the window frame: Min = left, top; Max = right, bottom. | |||
| FrameSize image.Rectangle | |||
…nly arg -- used for moves to ensure that only the top titlebar is in range.
…nd wingeom does not save Full or anything for that matter.
…eom; scene context menu has exit from fullscreen option when in fullscreen mode, and UpdateFullscreen uses the saved win geom to restore to original position after fullscreen -- all seems to be working on mac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add screen name to saved window geometry so it prefers to open there, and add option for screen name in opening new windows, in stage and lower level system api. also system.Window.Position() always returns screen-relative position. all working as expected.
Target bugs: #603 #997 and #1140
Also look at #947 and #509
Picks up from progress in #1339
b.NewWindow().SetScreen(1).RunMain()to specify screen 1 as the default to open a new window.