add warning when trying to create huge VRT #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
approved these changes
Apr 7, 2021
Comment on lines
+210
to
+212
| # Warns when the read resolution (tile, part) is lower than the | ||
| # resolution of the smaller overview. This will result in rasterio/rio-tiler | ||
| # creating a big WarpedVRT and trying to read a small part of it. |
There was a problem hiding this comment.
I'd put this in the second line of the warning message as well. Just saying
Trying to fetch lower resolution than min overview resolution
doesn't really tell anything to the user, and as a user I'd be confused why I'm getting warned at.
There was a problem hiding this comment.
yeah, TBH I'm still not sure about the warning, I hope I'll be able to find a solution instead 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #348
Still not sure how to resolve this issue, but for now here I added a warning when the output resolution is bigger than the small overview resolution.
The main problem is that in this case, rio-tiler will create a Huge VRT (matching the input bounds) and use
out_shapehttps://github.com/cogeotiff/rio-tiler/blob/master/rio_tiler/reader.py#L101 to fetch the data for the right overview. But when the output resolution is > to the min resolution for the COG, we will create a bigger VRT and still read part like 256x256 while in reality with might need only 10x10 pixel resampled to 256x256.