Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for stop #29

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Add tests for stop #29

merged 1 commit into from
Aug 31, 2024

Conversation

hedyhli
Copy link
Collaborator

@hedyhli hedyhli commented Aug 31, 2024

Opening a PR to draw your attention (sorry) in case you have better ideas for some of these:

  • Tests had to be split due to the nature of that function
  • On failure it would print both a PASS and a FAIL since we can't print anything after Stop successfully stops execution - if you can think of a better way I'd be glad!
  • Begin is tested because both begin and stop are implemented with catching errors in cognatejs, it might be helpful since these tests could be used for alternative cognate implementations

@StavromulaBeta StavromulaBeta merged commit 05c166f into master Aug 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants