Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove history buffer thingy #783

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Remove history buffer thingy #783

merged 3 commits into from
Feb 14, 2025

Conversation

einarmo
Copy link
Collaborator

@einarmo einarmo commented Feb 14, 2025

This was used to bridge the gap between history end and stream start. Now that state store is required when history is enabled, we no longer need this at all.

Copy link
Contributor

@ozangoktan ozangoktan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v3-dev@313e9b6). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             v3-dev     #783   +/-   ##
=========================================
  Coverage          ?   79.74%           
=========================================
  Files             ?      125           
  Lines             ?    16291           
  Branches          ?     2371           
=========================================
  Hits              ?    12991           
  Misses            ?     2581           
  Partials          ?      719           
Files with missing lines Coverage Δ
Extractor/History/EventExtractionState.cs 100.00% <ø> (ø)
Extractor/History/HistoryScheduler.cs 85.53% <ø> (ø)
Extractor/History/VariableExtractionState.cs 94.44% <ø> (ø)

@einarmo einarmo merged commit 5ad9c40 into v3-dev Feb 14, 2025
9 checks passed
@einarmo einarmo deleted the cleanup-state-store-stuff branch February 14, 2025 09:08
einarmo added a commit that referenced this pull request Feb 17, 2025
This was used to bridge the gap between history end and stream start. Now that state store is required when history is enabled, we no longer need this at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants