Patch for memory leak on event buffer #787
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same issue as the other memory leak, except caused by the buffer for events instead of the one for datapoints... The patch is even a little hackier, but I also realized that this feature only actually does _anything_ if influxdb is enabled (since that is the only target where we use the state of the target as state for events). Keep in mind that this entire feature is being removed completely in v3. To avoid breaking existing deployments I'm keeping it, ref discussion when we did this for the data point buffer, but I'm disabling it for deployments without influx, since it never worked for those.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #787 +/- ##
==========================================
- Coverage 80.05% 79.95% -0.11%
==========================================
Files 134 134
Lines 18836 18839 +3
Branches 2801 2800 -1
==========================================
- Hits 15079 15062 -17
- Misses 2911 2930 +19
- Partials 846 847 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same issue as the other memory leak, except caused by the buffer for events instead of the one for datapoints...
The patch is even a little hackier, but I also realized that this feature only actually does anything if influxdb is enabled (since that is the only target where we use the state of the target as state for events).
Keep in mind that this entire feature is being removed completely in v3. To avoid breaking existing deployments I'm keeping it, ref discussion when we did this for the data point buffer, but I'm disabling it for deployments without influx, since it never worked for those.