Skip to content

Commit

Permalink
fix: make CogniteClientPlayground optionality annotation stricter
Browse files Browse the repository at this point in the history
  • Loading branch information
haakonflatval-cognite committed May 25, 2022
1 parent d8ad572 commit 397ab09
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion viewer/core/src/public/createRevealManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export function createRevealManager(
renderer: THREE.WebGLRenderer,
sceneHandler: SceneHandler,
revealOptions: RevealOptions = {},
sdkPlayground?: CogniteClientPlayground
sdkPlayground?: CogniteClientPlayground | undefined
): RevealManager {
MetricsLogger.init(revealOptions.logMetrics !== false, project, applicationId, {
constructorOptions: revealOptions
Expand Down
2 changes: 1 addition & 1 deletion viewer/packages/pointclouds/src/PointCloudManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class PointCloudManager {
modelFactory: PointCloudFactory,
scene: THREE.Scene,
renderer: THREE.WebGLRenderer,
sdkPlayground?: CogniteClientPlayground
sdkPlayground?: CogniteClientPlayground | undefined
) {
this._pointCloudMetadataRepository = metadataRepository;
this._pointCloudFactory = modelFactory;
Expand Down
2 changes: 1 addition & 1 deletion viewer/packages/pointclouds/src/createPointCloudManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export function createPointCloudManager(
modelDataProvider: ModelDataProvider,
scene: THREE.Scene,
renderer: THREE.WebGLRenderer,
sdkPlayground: CogniteClientPlayground
sdkPlayground?: CogniteClientPlayground | undefined
): PointCloudManager {
const metadataRepository = new PointCloudMetadataRepository(modelMetadataProvider, modelDataProvider);
const modelFactory = new PointCloudFactory(modelDataProvider);
Expand Down

0 comments on commit 397ab09

Please sign in to comment.