Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Return annotationId of clicked point cloud object when doing picking #2235

Merged
merged 15 commits into from
Aug 4, 2022
Merged

improvement: Return annotationId of clicked point cloud object when doing picking #2235

merged 15 commits into from
Aug 4, 2022

Conversation

Savokr
Copy link
Contributor

@Savokr Savokr commented Jun 22, 2022 •
edited
Loading

Description

Adds support for getting annotationId of clicked point cloud object when picking. Also, fixes vertex attribute error in vertex shader of point cloud material.

Checklist:

  • I am proud of this feature. (actually more proud of shader error which I was able to trace)
  • I have performed a self-review of my own code.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@codecov
Copy link

codecov bot commented Jun 22, 2022 •
edited
Loading

Codecov Report

Merging #2235 (98304f5) into feat/point-cloud-styling (d765a15) will increase coverage by 1.03%.
The diff coverage is 59.77%.

@@                     Coverage Diff                      @@
##           feat/point-cloud-styling    #2235      +/-   ##
============================================================
+ Coverage                     70.37%   71.41%   +1.03%     
============================================================
  Files                           271      271              
  Lines                         11072    11219     +147     
  Branches                       1405     1437      +32     
============================================================
+ Hits                           7792     8012     +220     
+ Misses                         3123     3044      -79     
- Partials                        157      163       +6
Impacted Files Coverage Δ
viewer/.eslintrc.js 0.00% <ø> (ø)
viewer/index.ts 0.00% <0.00%> (ø)
viewer/internals.ts 0.00% <0.00%> (ø)
viewer/jest.config.js 0.00% <ø> (ø)
viewer/packages/api/src/migration.ts 0.00% <ø> (ø)
viewer/packages/api/src/public/RevealManager.ts 73.45% <ø> (ø)
...kages/api/src/public/migration/RenderController.ts 100.00% <ø> (ø)
viewer/packages/api/src/public/types.ts 100.00% <ø> (ø)
viewer/packages/api/src/utilities/Spinner.ts 84.37% <ø> (ø)
...ewer/packages/api/src/utilities/ViewStateHelper.ts 59.32% <ø> (ø)
... and 119 more

@Savokr Savokr changed the title improvement: Return objectId of clicked point cloud object when doing picking improvement: Return annotationId of clicked point cloud object when doing picking Jun 27, 2022
@Savokr Savokr added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Aug 1, 2022
@Savokr Savokr added preview-docs Deploy preview documentation for a PR slack PRs and issues with this label will be pushed to Slack labels Aug 3, 2022
@Savokr Savokr marked this pull request as ready for review August 3, 2022 15:42
@Savokr Savokr requested a review from a team as a code owner August 3, 2022 15:42
@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2022

This pull request introduces 1 alert when merging 8fdabe3 into 5018205 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/2235/docs/next/.

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/2235/docs/next/.

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/2235/docs/next/.

haakonflatval-cognite
haakonflatval-cognite approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a couple of suggestions

examples/src/pages/Migration.tsx Outdated Show resolved Hide resolved
documentation/docs/examples/click-reactions-pointcloud.mdx Outdated Show resolved Hide resolved
Savokr and others added 3 commits August 4, 2022 14:19
@Savokr @haakonflatval-cognite
Updated documentation
3811631 
Co-authored-by: Håkon Flatval <70905152+haakonflatval-cognite@users.noreply.github.com>
@Savokr
Changed console.log in migration
047a940
@Savokr
Merge branch 'savokr/pointcloud-picking-return-object-id' of https://…
98304f5 
…github.com/cognitedata/reveal into savokr/pointcloud-picking-return-object-id
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/2235/docs/next/.

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/2235/docs/next/.

@Savokr Savokr merged commit af815bc into feat/point-cloud-styling Aug 4, 2022
@Savokr Savokr deleted the savokr/pointcloud-picking-return-object-id branch August 4, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch preview-docs Deploy preview documentation for a PR slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Savokr @haakonflatval-cognite