Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggestion for setup that allows for libraries in workers.
Unfortunately, it seems like we won't be able to avoid bundling such libraries with Reveal. Currently, it is a bit unclear how exactly the dependency is bundled (whether within the worker itself or outside), and figuring this out is tracked as its own issue. A question has been posted by us on Stackoverflow on tips on how to achieve this, but it has so far seen little attention.
The approach in this PR is to split the Webpack configuration into two paths, one for the
index.js
entry point, and one for the rest ("peripheral entries"). Theindex.js
bundle has anexternals
-allow list that ensures it bundles additional dependencies in only that bundle, so we avoid unnecessary duplicates.This PR should target the point cloud feature branch, but targets another branch (at the time of writing) that is expected to be merged first. We may also discuss whether this should go directly to master, although that will a bit more inconvenient at this point, and seems unnecessary.
Checklist:
Here is a checklist that should completed before merging this given feature.
Any shortcomings from the items below should be explained and detailed within the contents of this PR.