Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport three due to commonjs import error #3440

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

christjt
Copy link
Contributor

Type of change

Bug

Description 📝

Fixes error importing threejs.

Once these two make it in, we should be able to bump again:
tweenjs/tween.js#661
tweenjs/tween.js#659

@christjt christjt added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jun 29, 2023
@christjt christjt requested a review from a team as a code owner June 29, 2023 09:03
@christjt christjt enabled auto-merge (squash) June 29, 2023 09:03
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3440 (a258470) into master (d197669) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3440   +/-   ##
=======================================
  Coverage   71.52%   71.53%           
=======================================
  Files         344      344           
  Lines       33241    33241           
  Branches     2583     2585    +2     
=======================================
+ Hits        23776    23778    +2     
+ Misses       9361     9359    -2     
  Partials      104      104           

see 1 file with indirect coverage changes

@christjt christjt merged commit 7fb0884 into master Jun 29, 2023
@christjt christjt deleted the christjt/backport-tween@19 branch June 29, 2023 09:15
@github-actions
Copy link

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/3440/docs/next/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants