Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-components): select single model simple list when has no scene #4746

Closed
wants to merge 33 commits into from
Closed

feat(react-components): select single model simple list when has no scene #4746

wants to merge 33 commits into from

Conversation

danpriori
Copy link
Contributor

@danpriori danpriori commented Sep 8, 2024 •
edited
Loading

Type of change

Feat

Jira ticket 📘

BND3D-3961

https://cognitedata.atlassian.net/browse/

Description 📝

This feature is to give the option to select single 3d models CAD or PCs when doesnt have Scenes in the project.
It will shows up a globe icon on the left toolbar when has no scene created for the project and when is clicked, it will open a list of 3d models to select.

How has this been tested? 🔍

Tested with simulating the project with no scenes by forcing the flag "hasScene" being false (returned by the hook useCheckIfHasScene) in order to force the icon being show and list the 3d models available on the project to be selected, as no project without any scenes it was able to find and test it.

Test instructions ℹ️

  1. Go to the project with no scenes (or force false the flag returned by useCheckIfHasScene hook)
  2. Open the Browser 3D
  3. Select the globe icon on the left toolbar above the Layers icon
  4. Select a 3d model
  5. Observe the 3d model showing in the 3d viewer

Note: this PR comes along with the PR in Fusion: https://github.com/cognitedata/fusion/pull/8080

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@danpriori danpriori requested a review from a team as a code owner September 8, 2024 21:32
@danpriori danpriori changed the title feat(react-components): select single model simple list feat(react-components): select single model simple list when has no scene Sep 8, 2024
pramodcog
pramodcog reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add few comments, will test the feature in a while!

pramodcog
pramodcog suggested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add storybook example.

@danpriori danpriori closed this Nov 25, 2024
@danpriori danpriori deleted the danpriori/BND3D-3961-select-single-model-simple-list branch November 25, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodcog pramodcog pramodcog requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danpriori @pramodcog