fix: Fix wrong event type in onHover #4861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilscognite
changed the title
pramodcog
reviewed
Nov 13, 2024
| @@ -7,7 +7,7 @@ | |||
| * @beta | |||
| */ | |||
| export class PointerEvents { | |||
| public onHover(_event: PointerEvent): void {} | |||
There was a problem hiding this comment.
Why Hover event is changed to MouseEvent?
PointerEvent basically inherits MouseEvent, if MouseEvent is used than Touch/Pen will not work
There was a problem hiding this comment.
I know. But hover is never used on Touch. The position of your finders are unknown anyway. So I wanted to synchronize it. sometimes it uses Mouse and sometime Pointer.
There was a problem hiding this comment.
I will update the API doc when you have approved.
pramodcog
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from PointEvent to MouseEvent everywhere when hover
And update to "version": "4.21.1