Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): support for CoreDM model loading and CoreDM point-cloud styling #4865

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

pramodcog
Copy link
Contributor

@pramodcog pramodcog commented Nov 14, 2024

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4711

Description 📝

The changes seems to be in too many but most of the changes are related to AddModelOption variable which was update in Reveal.
The core changes are related to support for CoreDM point cloud volume styling, search, clicking and asset mapping. Details can be found in Jira ticket.

Pending and workaround

  • Test for new hooks
  • RevealContainer test is removed due to failing test as a result of cyclic dependency in Architecture, error reference

How has this been tested? 🔍

In Storybook example and in Search application

Test instructions ℹ️

  • Storybook
    • Update createSdkByUrlToken.ts file with below details
      • 3d-test ---> 3d-dev-quickstart
      • https://greenfield.cognitedata.com ---> https://az-arn-dev-002.cognitedata.com
    • Run SceneContainer example.
  • Search Application
    • yalc link to fusion repo branch (pramodcog/BND3D-4712)
    • Load 3d-dev-quickstart project and Browse to 3D

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

react-components/stories/Architecture.stories.tsx Outdated Show resolved Hide resolved
react-components/src/utilities/isSameModel.ts Outdated Show resolved Hide resolved
react-components/src/utilities/isSameModel.ts Show resolved Hide resolved
): volumes is DMInstanceRef[] {
return volumes.every(
(volume): volume is DMInstanceRef =>
typeof volume === 'object' && volume !== null && 'externalId' in volume && 'space' in volume
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will say that I think only the two latter terms are necessary here, but I guess it's fine 😅

react-components/stories/SearchHooks.stories.tsx Outdated Show resolved Hide resolved
react-components/src/components/CacheProvider/types.ts Outdated Show resolved Hide resolved
@pramodcog pramodcog marked this pull request as ready for review November 26, 2024 22:05
@pramodcog pramodcog requested a review from a team as a code owner November 26, 2024 22:05
…nd use filtered model for further processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants