-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): support for CoreDM model loading and CoreDM point-cloud styling #4865
Open
pramodcog
wants to merge
36
commits into
master
Choose a base branch
from
pramodcog/BND3D-4711
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,636
−1,118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonflatval-cognite
requested changes
Nov 25, 2024
): volumes is DMInstanceRef[] { | ||
return volumes.every( | ||
(volume): volume is DMInstanceRef => | ||
typeof volume === 'object' && volume !== null && 'externalId' in volume && 'space' in volume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will say that I think only the two latter terms are necessary here, but I guess it's fine 😅
react-components/src/components/Reveal3DResources/useCadOrPointCloudResources.ts
Outdated
Show resolved
Hide resolved
react-components/src/components/Reveal3DResources/Reveal3DResources.tsx
Outdated
Show resolved
Hide resolved
react-components/src/components/CadModelContainer/CadModelContainer.tsx
Outdated
Show resolved
Hide resolved
…ptions classic hook
…nd use filtered model for further processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/BND3D-4711
Description 📝
The changes seems to be in too many but most of the changes are related to
AddModelOption
variable which was update in Reveal.The core changes are related to support for
CoreDM
point cloud volumestyling
,search
,clicking
andasset mapping
. Details can be found in Jira ticket.Pending and workaround
RevealContainer
test is removed due to failing test as a result of cyclic dependency inArchitecture
, error referenceHow has this been tested? 🔍
In Storybook example and in Search application
Test instructions ℹ️
Storybook
3d-test
--->3d-dev-quickstart
https://greenfield.cognitedata.com
--->https://az-arn-dev-002.cognitedata.com
SceneContainer
example.Search
Application3d-dev-quickstart
project and Browse to 3DChecklist ☑️