Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuboids #43

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Cuboids #43

wants to merge 4 commits into from

Conversation

Froggy618157725
Copy link
Collaborator

Adding Cuboid Utility objects. They can have each face adjusted independently by the scaling gizmo.

@cohaereo
Copy link
Owner

cohaereo commented Nov 8, 2024

Gonna wait with reviewing this until #36 is merged

@cohaereo
Copy link
Owner

@Froggy618157725 please rebase

This will cause utility shapes to be visible within things like
havok volumes, making them useful when visualizing the play area
bounds. Not a perfect solution, but much nicer for common use cases.
Some menu spawns weren't checking for finite coordinates.
Also cleaned up some other things just 'cause.
Cuboids can have any individual face adjusted by the scale gizmo.
They are limited to right angles.
@Froggy618157725
Copy link
Collaborator Author

The adjustments in "Add bidirectional scaling to the Gizmo" don't currently always work right. They're sometimes reversed. I haven't looked too much into that yet.

@cohaereo
Copy link
Owner

@Froggy618157725 scaling the cuboid using the gizmo doesn't play well with rotation
https://github.com/user-attachments/assets/33fbfa0f-ed40-4bf7-b5f5-cb51ef8dc624

@Froggy618157725
Copy link
Collaborator Author

@Froggy618157725 scaling the cuboid using the gizmo doesn't play well with rotation https://github.com/user-attachments/assets/33fbfa0f-ed40-4bf7-b5f5-cb51ef8dc624

Yeah :/ Probably grabbing the wrong matrix somewhere. Consequences of duck taping together 3 gizmos and pretending it's fine XD
It'll probably come down to a matrix multiply somewhere. Yay reference frames

@cohaereo
Copy link
Owner

@Froggy618157725 if you disable rotation on the cuboid's transform then we can merge this so you can figure out the rotation issue later. Or not, it's up to you : )

Will fix nicer gizmo later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants