Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to use-stick-to-bottom #803

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

samdenty
Copy link
Contributor

@samdenty samdenty commented Oct 6, 2024

This closes #799.

At stackblitz.com with the recent release of bolt.new, we created a new package npmjs.com/package/use-stick-to-bottom designed for AI chatbot interfaces which is much better than the non-maintained react-scroll-to-bottom package.

It features a custom smooth scrolling algorithm with a velocity-based spring animation so when new content jumps into view, it adjusts the velocity dynamically based on how much more new content was added resulting in a much less jumpy animation than the package you were using before

I also see you had to do some patch-package hacks - this new package is designed to work with the latest react without any errors

Copy link

cla-assistant bot commented Oct 6, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Oct 6, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@tianjing-li tianjing-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, did you have a chance to test the functionality?

@samdenty
Copy link
Contributor Author

samdenty commented Oct 9, 2024

This is great, did you have a chance to test the functionality?

I haven't tested no because I don't know how to, but maybe someone on your team wants to check it works. The hook itself is solid we've done extensive back and forth

@tianjing-li
Copy link
Collaborator

@samdenty I'll try to test this out when time permits

@tianjing-li tianjing-li added this pull request to the merge queue Oct 11, 2024
Merged via the queue into cohere-ai:main with commit f90aae1 Oct 11, 2024
6 checks passed
tianjing-li added a commit that referenced this pull request Oct 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 22, 2024
Revert "feat: switch to use-stick-to-bottom (#803)"

This reverts commit f90aae1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to a better smooth scrolling to bottom package, use-stick-to-bottom
2 participants