Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several minor UI improvements #52

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Several minor UI improvements #52

merged 4 commits into from
Jun 1, 2023

Conversation

MichlF
Copy link
Contributor

@MichlF MichlF commented May 25, 2023

I was bugged by a few aspects about the UI so I wrote a small PR to fix them.
Hope you also consider them to be an improvement.

MichlF added 3 commits May 25, 2023 23:18
@MichlF
Added explicit faction and country name tooltip
205f7e4
@MichlF
Settings tab visual improvements
23563ef 
- Added missing tool tip for play sound
- Minor text improvements
- Increase file box widths to increase file path readability
@MichlF
Removal of redundant imports and field definitions
676e416
@petrvecera
Copy link
Member

petrvecera commented May 26, 2023 via email

petrvecera
petrvecera requested changes May 26, 2023
View reviewed changes
Copy link
Member

@petrvecera petrvecera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, otherwise looks good 👍

src/utils/renameLabels.tsx Outdated Show resolved Hide resolved
@MichlF MichlF requested a review from petrvecera June 1, 2023 13:48
petrvecera
petrvecera approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@petrvecera petrvecera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I want to make some additional improvements for the streaming with the desktop app. We could do new release next week 👍

@petrvecera petrvecera merged commit 697b94f into cohstats:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrvecera petrvecera petrvecera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichlF @petrvecera