Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report step on CI #1602

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix report step on CI #1602

merged 2 commits into from
Nov 14, 2024

Conversation

hendrikmakait
Copy link
Member

No description provided.

@hendrikmakait
Copy link
Member Author

tests/tpch/conftest.py Show resolved Hide resolved
Comment on lines 262 to 268
script: |
const workflow_url = `https://github.com/${process.env.GITHUB_REPOSITORY}/actions/runs/${process.env.GITHUB_RUN_ID}`
const issue_body = `[Workflow Run URL](${workflow_url})`
github.issues.create({
github.rest.issues.create({
owner: context.repo.owner,
repo: context.repo.repo,
body: issue_body,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to do anything here, but just wanted to note that the original version of this code has been moved into it's own GitHub action https://github.com/xarray-contrib/issue-from-pytest-log which is what we're now using in dask/dask

https://github.com/dask/dask/blob/98331028f8a51d404f8c9856d49ba726322c4e03/.github/workflows/upstream.yml#L76-L86

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, this is mostly just an FYI

@hendrikmakait hendrikmakait merged commit 52f7d33 into main Nov 14, 2024
12 of 15 checks passed
@hendrikmakait hendrikmakait deleted the fix-ci-report branch November 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants