Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miniconda to fix CI #1630

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Update miniconda to fix CI #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8678fae
Fix CI
hendrikmakait Dec 16, 2024
7d1e422
Pin to 3.1
hendrikmakait Dec 16, 2024
82b5832
Pin to 3
hendrikmakait Dec 16, 2024
b296bd3
Remove defaults channel
hendrikmakait Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ab_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ jobs:
use-mamba: true
condarc-file: ci/condarc
environment-file: AB_environments/${{ matrix.runtime-version }}.conda.yaml
conda-remove-defaults: "true"

- name: Add test dependencies
run: mamba env update --file ci/environment-test.yml
Expand Down Expand Up @@ -180,6 +181,7 @@ jobs:
miniforge-version: latest
use-mamba: true
environment-file: ci/environment-dashboard.yml
conda-remove-defaults: "true"

- name: Generate dashboards
run: python dashboard.py -d benchmark.db -o static -b all
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/geospatial.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
condarc-file: ci/condarc
python-version: "3.10"
environment-file: ci/environment.yml
conda-remove-defaults: "true"

- name: Add geospatial dependencies
run: mamba env update --file ci/environment-geospatial.yml
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,14 @@ jobs:
uses: actions/checkout@v4

- name: Set up environment
uses: conda-incubator/setup-miniconda@v3.0.4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the relevant change, the rest is just pinning consistently to the minor version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have overestimated the capabilities of this action. Consistently pinning to v3 now.

uses: conda-incubator/setup-miniconda@v3
with:
miniforge-version: latest
use-mamba: true
condarc-file: ci/condarc
python-version: ${{ matrix.python_version }}
environment-file: ci/environment.yml
conda-remove-defaults: "true"

- name: Add extra packages to environment
if: ${{ matrix.extra-env != '' }}
Expand Down Expand Up @@ -225,6 +226,7 @@ jobs:
miniforge-version: latest
use-mamba: true
environment-file: ci/environment-dashboard.yml
conda-remove-defaults: "true"

- name: Run detect regressions
run: |
Expand Down Expand Up @@ -291,6 +293,7 @@ jobs:
miniforge-version: latest
use-mamba: true
environment-file: ci/environment-dashboard.yml
conda-remove-defaults: "true"

- name: Generate dashboards
run: python dashboard.py -d benchmark.db -o static
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tpch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ jobs:
condarc-file: ci/condarc
python-version: "3.10"
environment-file: ci/environment.yml
conda-remove-defaults: "true"

- name: Add TPC-H non-dask dependencies
run: mamba env update --file ci/environment-tpch-nondask.yml
Expand Down
Loading