Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use package sync #222

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
branches:
- main
tags:
- '*'
- "*"
pull_request:
schedule:
# Runs "At 00:01" (see https://crontab.guru)
Expand Down Expand Up @@ -392,7 +392,7 @@ jobs:
env:
AWS_ACCESS_KEY_ID: ${{ secrets.RUNTIME_CI_BOT_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.RUNTIME_CI_BOT_AWS_SECRET_ACCESS_KEY }}
AWS_DEFAULT_REGION: us-east-2 # this is needed for boto for some reason
AWS_DEFAULT_REGION: us-east-2 # this is needed for boto for some reason
DB_NAME: benchmark.db
run: |
aws s3 cp s3://coiled-runtime-ci/benchmarks/$DB_NAME . || true
Expand All @@ -406,7 +406,7 @@ jobs:
env:
AWS_ACCESS_KEY_ID: ${{ secrets.RUNTIME_CI_BOT_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.RUNTIME_CI_BOT_AWS_SECRET_ACCESS_KEY }}
AWS_DEFAULT_REGION: us-east-2 # this is needed for boto for some reason
AWS_DEFAULT_REGION: us-east-2 # this is needed for boto for some reason
DB_NAME: benchmark.db
run: |
aws s3 cp $DB_NAME s3://coiled-runtime-ci/benchmarks/
Expand Down
3 changes: 2 additions & 1 deletion conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def get_coiled_software_name():
dask.config.set(
{
"coiled.account": "dask-engineering",
"coiled.software": get_coiled_software_name(),
# "coiled.software": get_coiled_software_name(),
}
)

Expand Down Expand Up @@ -249,6 +249,7 @@ def small_cluster(request):
worker_vm_types=["t3.large"],
scheduler_vm_types=["t3.large"],
backend_options=backend_options,
package_sync=True,
) as cluster:
yield cluster

Expand Down
4 changes: 3 additions & 1 deletion tests/benchmarks/test_coiled.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@

def test_default_cluster_spinup_time(request):

with Cluster(name=f"{request.node.originalname}-{uuid.uuid4().hex[:8]}"):
with Cluster(
name=f"{request.node.originalname}-{uuid.uuid4().hex[:8]}", package_sync=True
):
pass
1 change: 1 addition & 0 deletions tests/benchmarks/test_parquet.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def parquet_cluster():
n_workers=N_WORKERS,
worker_vm_types=["m5.xlarge"],
scheduler_vm_types=["m5.xlarge"],
package_sync=True,
) as cluster:
yield cluster

Expand Down
1 change: 1 addition & 0 deletions tests/stability/test_deadlock.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ def test_repeated_merge_spill(upload_cluster_dump):
name=f"test_deadlock-{uuid.uuid4().hex}",
n_workers=20,
worker_vm_types=["t3.medium"],
package_sync=True,
) as cluster:
with Client(cluster) as client:
with upload_cluster_dump(client, cluster):
Expand Down