Ensure concurrent restarts are not interfering #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
commented
Nov 15, 2022
| @@ -15,7 +15,7 @@ repos: | |||
| - id: black | |||
| language_version: python3 | |||
| exclude: ^alembic/versions/ | |||
| - repo: https://gitlab.com/pycqa/flake8 | |||
There was a problem hiding this comment.
I know this should not be in here. I got weird auth errors when downloading from gitlab. I suggest to just use the github mirror. If requested, I can break this out into another PR
There was a problem hiding this comment.
it might have been a typo. Should we use
rev: 5.0.4 like we do in dask and distributed.
There was a problem hiding this comment.
I'll give this a try, hope you don't mind pushing to your PR. If things are green I'll merge this in.
|
Other occurrences of restart should not be affected since this only comes up if we call restart twice in short succession |
ncclementi
approved these changes
Nov 15, 2022
This was referenced Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation why this bypasses the race condition in the comment. See also dask/distributed#7312
Closes #468