Permit to compile qpOASES as a shared library in CMake #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
force-pushed
the
fix/shared/cmake
branch
from
4177d3a
to
cb49b52
Compare
apotschka
approved these changes
Mar 8, 2021
|
Thanks a lot for fixing these CMake-related issues. |
|
@traversaro, please add your name to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification permits to compile qpOASES on Unix as a shared library, leaving the default compilation to static for backward compatibility. Enabling the
BUILD_SHARED_LIBSoption in CMake is explicitly disabled as visibility of symbols is not handled in the project, and usingCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS(see https://blog.kitware.com/create-dlls-on-windows-without-declspec-using-new-cmake-export-all-feature/) is not working due to the use of some global variables (struct _iobuf * qpOASES::stdFile).