Expose toAddressId() method on Transaction class

CHANGELOG.md

@@ -1,10 +1,12 @@
 # Coinbase Node.js SDK Changelog
 
-## [0.1.0]
+## Unreleased
 
 ### Added
 
 - Add historical_balances function for wallet: listing historical balances for default address of the wallet.
+- Add toAddressId() method to Transaction class
+- Remove "pending" status from StakingOperationStatusEnum
 
 ## [0.0.16] - 2024-08-14
 

src/client/api.ts

@@ -1439,7 +1439,6 @@ export interface StakingOperation {
 
 export const StakingOperationStatusEnum = {
     Initialized: 'initialized',
-    Pending: 'pending',
     Complete: 'complete',
     Failed: 'failed',
     Unspecified: 'unspecified'

src/coinbase/transaction.ts

@@ -79,6 +79,15 @@ export class Transaction {
     return this.model.from_address_id;
   }
 
+  /**
+   * Returns the To Address ID for the Transaction if it's available.
+   *
+   * @returns The To Address ID
+   */
+  toAddressId(): string | undefined {
+    return this.model.to_address_id;
+  }
+
   /**
    * Returns whether the Transaction is in a terminal State.
    *

src/tests/external_address_test.ts

@@ -4,12 +4,9 @@ import {
   externalAddressApiMock,
   generateRandomHash,
   getAssetMock,
-  mockEthereumValidator,
   mockReturnValue,
   newAddressModel,
   stakeApiMock,
-  VALID_ACTIVE_VALIDATOR_LIST,
-  VALID_ADDRESS_MODEL,
   validatorApiMock,
 } from "./utils";
 import {
@@ -21,6 +18,7 @@ import {
   StakingOperation as StakingOperationModel,
   StakingRewardFormat,
   StakingRewardStateEnum,
+  StakingOperationStatusEnum,
 } from "../client";
 import Decimal from "decimal.js";
 import { ExternalAddress } from "../coinbase/address/external_address";
@@ -70,7 +68,7 @@ describe("ExternalAddress", () => {
     id: randomUUID(),
     network_id: Coinbase.networks.EthereumHolesky,
     address_id: "0x1234567890",
-    status: "pending",
+    status: StakingOperationStatusEnum.Initialized,
     transactions: [
       {
         from_address_id: address.getId(),

src/tests/staking_operation_test.ts

@@ -34,7 +34,10 @@ describe("StakingOperation", () => {
     it("return the the array of transactions", () => {
       const op = new StakingOperation(VALID_STAKING_OPERATION_MODEL);
       expect(op.getTransactions().length).toEqual(1);
-      expect(op.getStatus()).toEqual(StakingOperationStatusEnum.Pending);
+      expect(op.getTransactions()[0].toAddressId()).toEqual("dummy-to-address-id");
+      expect(op.getTransactions()[0].fromAddressId()).toEqual("dummy-from-address-id");
+      expect(op.getTransactions()[0].getTransactionHash()).toEqual("0xdummy-transaction-hash");
+      expect(op.getStatus()).toEqual(StakingOperationStatusEnum.Initialized);
     });
   });
 
@@ -123,7 +126,7 @@ describe("StakingOperation", () => {
     it("all getters should work", async () => {
       const stakingOperation = new StakingOperation(VALID_STAKING_OPERATION_MODEL);
       expect(stakingOperation.getID()).toBe("some-id");
-      expect(stakingOperation.getStatus()).toBe(StakingOperationStatusEnum.Pending);
+      expect(stakingOperation.getStatus()).toBe(StakingOperationStatusEnum.Initialized);
       expect(stakingOperation.isTerminalState()).toBe(false);
       expect(stakingOperation.getTransactions().length).toBe(1);
       expect(stakingOperation.getSignedVoluntaryExitMessages().length).toBe(0);

src/tests/utils.ts

@@ -172,11 +172,12 @@ export const VALID_STAKING_OPERATION_MODEL: StakingOperationModel = {
   id: "some-id",
   network_id: Coinbase.networks.EthereumHolesky,
   address_id: "some-address-id",
-  status: "pending",
+  status: StakingOperationStatusEnum.Initialized,
   transactions: [
     {
       network_id: Coinbase.networks.EthereumHolesky,
-      from_address_id: "0xdeadbeef",
+      from_address_id: "dummy-from-address-id",
+      to_address_id: "dummy-to-address-id",
       unsigned_payload:
         "7b2274797065223a22307832222c22636861696e4964223a2230783134613334222c226e6f6e63" +
         "65223a22307830222c22746f223a22307834643965346633663464316138623566346637623166" +
@@ -188,7 +189,7 @@ export const VALID_STAKING_OPERATION_MODEL: StakingOperationModel = {
         "2c2273223a22307830222c2279506172697479223a22307830222c2268617368223a2230783664" +
         "633334306534643663323633653363396561396135656438646561346332383966613861363966" +
         "3031653635393462333732386230386138323335333433227d",
-      transaction_hash: "0xdeadbeef",
+      transaction_hash: "0xdummy-transaction-hash",
       transaction_link: "https://sepolia.basescan.org/tx/0xdeadbeef",
       status: "pending",
     },