Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #184

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Update docs #184

merged 1 commit into from
Aug 26, 2024

Conversation

drohit-cb
Copy link
Contributor

What changed? Why?

I noticed that some of the functionality I added in v0.1.0 wasn't showing up in the corresponding docs.

Running npm run docs produces the files updated/added in this PR.

Qualified Impact

@drohit-cb drohit-cb requested a review from alex-stone August 26, 2024 20:16
@@ -13,33 +13,36 @@
<a href="coinbase_transaction.Transaction.html#isTerminalState" class="tsd-index-link"><svg class="tsd-kind-icon" viewBox="0 0 24 24"><use href="../assets/icons.svg#icon-2048"></use></svg><span>is<wbr/>Terminal<wbr/>State</span></a>
<a href="coinbase_transaction.Transaction.html#rawTransaction" class="tsd-index-link"><svg class="tsd-kind-icon" viewBox="0 0 24 24"><use href="../assets/icons.svg#icon-2048"></use></svg><span>raw<wbr/>Transaction</span></a>
<a href="coinbase_transaction.Transaction.html#sign" class="tsd-index-link"><svg class="tsd-kind-icon" viewBox="0 0 24 24"><use href="../assets/icons.svg#icon-2048"></use></svg><span>sign</span></a>
<a href="coinbase_transaction.Transaction.html#toAddressId" class="tsd-index-link"><svg class="tsd-kind-icon" viewBox="0 0 24 24"><use href="../assets/icons.svg#icon-2048"></use></svg><span>to<wbr/>Address<wbr/>Id</span></a>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one I was hoping to see in the published docs.

@drohit-cb drohit-cb changed the base branch from v0.2.0 to master August 26, 2024 20:25
@cb-heimdall
Copy link

cb-heimdall commented Aug 26, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@drohit-cb drohit-cb marked this pull request as ready for review August 26, 2024 20:25
@cb-heimdall
Copy link

Review Error for alex-stone @ 2024-08-26 20:27:55 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@drohit-cb drohit-cb merged commit 5a034db into master Aug 26, 2024
3 of 4 checks passed
@cb-heimdall
Copy link

This Pull Request was merged without enough reviews
Please go here to review and +1

@drohit-cb drohit-cb deleted the update_docs branch August 26, 2024 20:33
@cb-heimdall
Copy link

This Pull Request was merged without enough reviews
Please go here to review and +1

1 similar comment
@cb-heimdall
Copy link

This Pull Request was merged without enough reviews
Please go here to review and +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants