Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fund and quoteFund interfaces to take objects and added listFundOperations #330

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Update fund and quoteFund interfaces to take objects and added listFundOperations #330

merged 6 commits into from
Dec 4, 2024

Conversation

rohan-agarwal-coinbase
Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase commented Dec 4, 2024 •
edited
Loading

What changed? Why?

  • Updates interface to take options object
  • Added listFundOperations to wallet_address and wallet

Testing

  • New unit tests added and tests pass

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Dec 4, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@rohan-agarwal-coinbase rohan-agarwal-coinbase changed the title Update fund and quoteFund interfaces to take objects and added listFunds Update fund and quoteFund interfaces to take objects and added listFundOperations Dec 4, 2024
@rohan-agarwal-coinbase rohan-agarwal-coinbase merged commit e343f7c into master Dec 4, 2024
6 checks passed
@rohan-agarwal-coinbase rohan-agarwal-coinbase deleted the rohan/fix-fund-quote branch December 4, 2024 22:12
@rohan-agarwal-coinbase rohan-agarwal-coinbase restored the rohan/fix-fund-quote branch December 4, 2024 22:12
@rohan-agarwal-coinbase rohan-agarwal-coinbase mentioned this pull request Dec 4, 2024
Merged
@rohan-agarwal-coinbase rohan-agarwal-coinbase deleted the rohan/fix-fund-quote branch December 4, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-stone alex-stone alex-stone approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohan-agarwal-coinbase @cb-heimdall @alex-stone