feat: Support async faucet transactions #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-stone
force-pushed
the
stone/faucet-tx-wait
branch
2 times, most recently
from
51567c8 to
b61c3df
Compare
This adds support for asynchronous faucet transactions. This will make faucet transactions consistent with other transactions and will make them more stable, as we can poll for the status on the SDK side rather than on the server side. ``` faucet_tx = wallet.faucet faucet_tx.wait! ``` or ``` wallet.faucet.wait! ```
alex-stone
force-pushed
the
stone/faucet-tx-wait
branch
from
b61c3df to
4e18b95
Compare
John-peterson-coinbase
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This adds support for asynchronous faucet transactions. This will
make faucet transactions consistent with other transactions and will
make them more stable, as we can poll for the status on the SDK side
rather than on the server side.
or
Qualified Impact