chore: Fix Smart Contract reads without ABI specified #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Smart Contract reads with no ABI specified. We support
using ABIs from our deployed smart contracts and well known asset
standards, namely ERC20, ERC721, and ERC1155 token contracts.
```
asset = Coinbase::Asset.fetch('base-sepolia', 'usdc')
Coinbase::SmartContract.read(
network: Coinbase::Network::BASE_SEPOLIA,
contract_address: asset.address_id,
method: 'balanceOf',
args: { account: "alexstone.base.eth"},
)
```
rohan-agarwal-coinbase
approved these changes
Nov 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This fixes Smart Contract reads with no ABI specified. We support using ABIs from our deployed smart contracts and well known asset standards, namely ERC20, ERC721, and ERC1155 token contracts.
How to test this
Make a request to read a well known ERC20 asset without specifying an ABI:
Qualified Impact