BugFix: Add CoinSupported configuration #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently every check:construction tries to fetch coins but not every rosetta implementations support coin endpoint (e.g. rosetta-ethereum).
3 tasks
|
Hi reviewers :) PTAL this PR and related issue. |
|
Review Error for shiatcb @ 2022-04-05 14:52:43 UTC |
shrimalmadhur
approved these changes
Apr 5, 2022
|
@aeharvlee can you sign the commits. That's a required step before I can merge. Thank you! |
|
@aeharvlee I made a copy to your PR so we can quickly merge and release: #297 (don't worry, I linked to this original PR and @ your name). Please close this one. Thanks in advance! |
|
Closing this due to #297 . Thanks @aeharvlee for the PR, sorry we had to push it fast due to an urgent blocker. Appreciate the contribution though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently every check:construction tries to fetch coins but not every rosetta implementations support coin endpoint (e.g. rosetta-ethereum).
This PR Fixes #294
Motivation
account/coins).Solution