Improve parsing logic for set_variable
action types
#371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes coinbase/mesh-cli#248
Motivation
To improve the parsing logic for
set_variable
action typesSolution
Before splitting the string to determine if the remaining line contains an arithmetic operator, we first check to see if the remaining line (sans
;
suffix) is valid JSONOpen questions
Is there any possibility of arithmetic and JSON in the same line?