Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pallas support ImportPrivateKey #385

Merged
merged 6 commits into from
Feb 23, 2022
Merged

Conversation

irisZhangCB
Copy link
Contributor

Fixes # .

Motivation

  • ImportPrivateKey didn't add Pallas curve type.
  • There's discrepancy between how kryptology and rosetta process payload. Added functions to concert payload to work with kryptology

Solution

Open questions

@irisZhangCB irisZhangCB marked this pull request as ready for review February 22, 2022 16:34
@shrimalmadhur shrimalmadhur reopened this Feb 22, 2022
@@ -28,31 +27,27 @@ var keypair *KeyPair
var txnBytes []byte

func init() {
keypair, _ = GenerateKeypair(types.Pallas)
keypair, _ = ImportPrivateKey(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more test cases for covering edge cases since there are lot of if loops while executing constructTransaction

@shrimalmadhur shrimalmadhur merged commit db9ef69 into coinbase:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants