Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect code snippet in semgrep sarif #718

Merged
merged 0 commits into from
Oct 7, 2022
Merged

fix incorrect code snippet in semgrep sarif #718

merged 0 commits into from
Oct 7, 2022

Conversation

ghbren
Copy link
Contributor

@ghbren ghbren commented Oct 6, 2022 •
edited
Loading

Fixed semgrep sarif bug below:

If the code snippet itself has :, like abc: [val], then the snippet would only contain abc.

@ghbren ghbren requested a review from maitrayshah-cb October 6, 2022 23:02
@ghbren ghbren merged this pull request into master Oct 7, 2022
@ghbren ghbren deleted the semgrep_incomplete_snippet branch October 7, 2022 18:07
@ghbren ghbren mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maitrayshah-cb maitrayshah-cb maitrayshah-cb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghbren @maitrayshah-cb