Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword arguments support to Activity classes #255

Merged

Conversation

santiagodoldan
Copy link
Contributor

No description provided.

@santiagodoldan
Copy link
Contributor Author

Hello everyone 👋 , here a small change that will allow the usage of keyword arguments in activities

class MyWorkflow < Temporal::Workflow
  def execute(args)
     MyActivity.execute!(user_id: args[:user_id])

     ...
  end
end

class MyActivity < Temporal::Activity
  def execute(user_id:)
    puts user_id
  end
end

I'm open to discuss any changes and please let me know if you can see any possible issues because of my changes so I can try to fix them 🙌

@santiagodoldan
Copy link
Contributor Author

lib/temporal/activity.rb Outdated Show resolved Hide resolved
@santiagodoldan santiagodoldan force-pushed the add-kwargs-support-to-activities branch from 5df9539 to d059356 Compare July 29, 2023 20:42
@DeRauk
Copy link
Contributor

DeRauk commented Jan 4, 2024

@santiagodoldan I missed merging this back in July 😬 . Do you mind rebasing and pushing again to get a new test run? I'd be happy to merge then.

@santiagodoldan santiagodoldan force-pushed the add-kwargs-support-to-activities branch from d059356 to 24343ba Compare January 5, 2024 12:38
@santiagodoldan
Copy link
Contributor Author

@DeRauk Thanks 🙌

@DeRauk
Copy link
Contributor

DeRauk commented Jan 5, 2024

@santiagodoldan could you take a look at the failing tests?

@santiagodoldan santiagodoldan force-pushed the add-kwargs-support-to-activities branch from 24343ba to 9d02ec8 Compare January 5, 2024 15:45
@santiagodoldan
Copy link
Contributor Author

@DeRauk It should be fine now 💯

@DeRauk DeRauk merged commit 95d62d2 into coinbase:master Jan 5, 2024
2 checks passed
@santiagodoldan santiagodoldan deleted the add-kwargs-support-to-activities branch January 5, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants