Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #282

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Fix warnings #282

merged 2 commits into from
Jan 16, 2024

Conversation

jeffschoner
Copy link
Contributor

Fixes a couple of warnings

  • Adds the base64 gem to the gemspec. Starting in Ruby 3.4.0, this will be required since it's moving out of the standard library. For 3.3.0, this is showing up as a warning. See https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/ for more information
  • Assertions that specs do not raise a specific error have been made more general to assert that a test raises no error at all. This removes a warning and should make these tests slightly more robust

@DeRauk DeRauk merged commit 3e0dae7 into coinbase:master Jan 16, 2024
2 checks passed
@jeffschoner jeffschoner deleted the small-fixes branch January 21, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants