Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for burnt CargoX tokens #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janezkranjc
Copy link

CargoX burns tokens as part of its business model and token mechanics. In this PR I added logic that subtracts the burnt tokens (sent to 0x0 address) from the circulating supply.

@valentinbora
Copy link
Collaborator

@janezkranjc technically, the getTokenInfo Ethplorer method should provide the circulating supply already subtracting burnt coins (so I'm concerned about a potential update there, which might determine us to subtract twice). Do you think we should differentiate between circulating and available supply here?

In any case, both on Ethplorer and Etherscan, the circulating/available supply is updated manually AFAIK.

Let me know your thoughts. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants