Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the registry pkg #12

Merged
merged 6 commits into from
Oct 12, 2023
Merged

feat: add the registry pkg #12

merged 6 commits into from
Oct 12, 2023

Conversation

AaronCQL
Copy link
Member

@AaronCQL AaronCQL commented Oct 11, 2023

Refactor of #8:

  • Shifted all code to the registry pkg
  • Exported names changed to the following:
    export type { ChainRegistryAssetList } from "./types/ChainRegistryAssetList";
    export type { ChainRegistryChainInfo } from "./types/ChainRegistryChainInfo";
    export type { KeplrChainInfo } from "./types/KeplrChainInfo";
    
    export { getChainRegistryAssetList } from "./apis/getChainRegistryAssetList";
    export { getChainRegistryChainInfo } from "./apis/getChainRegistryChainInfo";
    export { toKeplrChainInfo } from "./keplr/toKeplrChainInfo";
  • Function signature of toKeplrChainInfo changed to:
    function toKeplrChainInfo(
      chainRegistryChainInfo: ChainRegistryChainInfo,
      chainRegistryAssetList: ChainRegistryAssetList,
      options?: {...}
    ): KeplrChainInfo
  • Added script to generate the Chain Registry types

@AaronCQL AaronCQL self-assigned this Oct 11, 2023
@AaronCQL AaronCQL requested a review from ryoid October 11, 2023 10:09
@ryoid ryoid mentioned this pull request Oct 12, 2023
Copy link
Contributor

@ryoid ryoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronCQL AaronCQL merged commit c7c2964 into main Oct 12, 2023
1 check passed
@AaronCQL AaronCQL deleted the aaron/feat-registry-pkg branch October 15, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants